cleanup

3 files changed, 4 insertions, 57 deletions

diff --git a/src/device_context.cc b/src/device_context.cc
index 2c57b7e..b8d3482 100644
--- a/src/device_context.cc
+++ b/src/device_context.cc
@@ -1,5 +1,4 @@
 #include "device_context.hh"
-#include "queue_context.hh"
 
 #include <iostream>
 #include <utility>
diff --git a/src/timestamp_pool.cc b/src/timestamp_pool.cc
index cf48873..01afe07 100644
--- a/src/timestamp_pool.cc
+++ b/src/timestamp_pool.cc
@@ -147,34 +147,6 @@ TimestampPool::Handle::get_ticks(const TimestampPool& pool) {
     return query_result.value;
 }
 
-/*
-void TimestampPool::poll() {
-    const auto& device_context = this->queue_context.device_context;
-
-    std::ranges::transform(
-        this->blocks, std::back_inserter(this->cached_timestamps),
-        [&, this](const auto& block) {
-            const auto& query_pool = block.query_pool;
-
-            auto timestamps = std::make_unique<std::vector<std::uint64_t>>(
-                this->TIMESTAMP_QUERY_POOL_SIZE);
-
-            const auto result = device_context.vtable.GetQueryPoolResults(
-                device_context.device, query_pool, 0,
-                this->TIMESTAMP_QUERY_POOL_SIZE,
-                this->TIMESTAMP_QUERY_POOL_SIZE * sizeof(std::uint64_t),
-                std::data(*timestamps), sizeof(uint64_t),
-                VK_QUERY_RESULT_64_BIT);
-
-            // Might return not ready when any of them aren't ready, which
-            // is not an error for our use case.
-            assert(result == VK_SUCCESS || result == VK_NOT_READY);
-
-            return timestamps;
-        });
-};
-*/
-
 TimestampPool::~TimestampPool() {
     const auto& device = this->queue_context.device_context.device;
     const auto& vtable = this->queue_context.device_context.vtable;
diff --git a/src/timestamp_pool.hh b/src/timestamp_pool.hh
index f69b06f..681c9e2 100644
--- a/src/timestamp_pool.hh
+++ b/src/timestamp_pool.hh
@@ -3,37 +3,13 @@
 
 // The purpose of this file is to provide the definition of a 'timestamp pool'.
 // It manages blocks of timestamp query pools, hands them out when requested,
-// and allocates more when (if) we run out. It also efficiently reads them back.
-// This class solves some key issues:
-//
-// 1. We need a potentially infinite amount of timestamps available to the
-// GPU. While I imagine most (good) applications will limit the amount of
-// times they call vkQueueSubmit, there's no bound we can place on the
-// amount of times this function will be called. Also,
-// the amount of frames in flight might vary, so really we need
-// num_queue_submits * max_frames_in_flight timestamps. Obviously, we don't
-// know what these numbers are at runtime and can't assume that they are
-// reasonable or even constant either. We solve this by allocating more
-// timestamps when necessary.
-
-// 2. We don't want to hammer vulkan with expensive timestamp read
-// operations. If we have hundreds of query pools lying around, reading them
-// back will take hundreds of individual vulkan calls. They
-// should be batched as to perform as few reads as possible. So if we allocate
-// multiple big query pool strips, then reading them will only require that many
-// calls. We then can cache off the result of reading as well so iterating
-// through later doesn't require any vulkan interaction at all.
-//
-//
+// and allocates more when (if) we run out.
 // Usage:
 //     1. Get handle with .acquire().
 //     2. Write start/end timestamp operations with the handle's pool and index
-//     into the provided command buffer.
-//     3. With the command buffer signalled completion via some semaphore /
-//     fence, call .poll(). This will cache off all outstanding handles.
-//     Retrieving with handles which have not been signalled are undefined.
-//     4. Retrieve timestamp results with .get_polled(your_handle).
-//     5. Destruct the handle to return the key to the pool.
+//     into the provided command buffer. Will return nullopt if they're
+//     not yet available.
+//     3. Destruct the handle to return the key to the pool.
 
 #include <vulkan/utility/vk_dispatch_table.h>
 #include <vulkan/vulkan.hpp>